[PATCH] D101304: AMDGPU/llvm-readobj: Add missing tests for note parsing/displaying

[Konstantin Zhuravlyov via Phabricator via llvm-commits]

kzhuravl created this revision.
kzhuravl added a reviewer: jhenderson.
Herald added subscribers: rupprecht, hiraditya, t-tye, tpr, dstuttard, yaxunl, emaste, rampitec.
kzhuravl requested review of this revision.
Herald added subscribers: MaskRay, wdng.
Herald added a project: LLVM.

This is a follow up review/change for https://reviews.llvm.org/D95638

Add valid note tests for code object v2 notes:

- NT_AMD_HSA_CODE_OBJECT_VERSION (required yaml2obj update)
- NT_AMD_HSA_HSAIL (required yaml2obj update)
- NT_AMD_HSA_ISA_VERSION (required yaml2obj update)
- NT_AMD_HSA_METADATA
- NT_AMD_HSA_ISA_NAME
- NT_AMD_PAL_METADATA

Add valid note tests for code object v3 notes:

- NT_AMDGPU_METADATA

Add invalid note tests for code object v2 notes:

- NT_AMD_HSA_CODE_OBJECT_VERSION (required yaml2obj update)
- NT_AMD_HSA_HSAIL (required yaml2obj update)
- NT_AMD_HSA_ISA_VERSION (required yaml2obj update)

Add invalid note tests for code object v3 notes:

- NT_AMDGPU_METADATA


https://reviews.llvm.org/D101304

Files:
  llvm/lib/ObjectYAML/ELFYAML.cpp
  llvm/test/tools/llvm-readobj/ELF/note-amd-invalid-v2.s
  llvm/test/tools/llvm-readobj/ELF/note-amd-invalid-v3.s
  llvm/test/tools/llvm-readobj/ELF/note-amd-valid-v2.s
  llvm/test/tools/llvm-readobj/ELF/note-amd-valid-v3.s
  llvm/tools/llvm-readobj/ELFDumper.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D101304.340551.patch
Type: text/x-patch
Size: 30037 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210426/87ad99b9/attachment.bin>