[PATCH] D101470: [XCOFF][AIX] Peephole optimization in TocData transformation

Wed Apr 28 17:57:10 PDT 2021

sfertile added a comment.

Awesome work Sidarth, patch looks really good. I've got one initial comment.

================
Comment at: llvm/lib/Target/PowerPC/PPCISelDAGToDAG.cpp:7096
+    case PPC::ADDItoc:
       Flags = PPCII::MO_TOC_LO;
       break;
----------------
This flag represents emitting a specific relocation (ie producing an object file) or a specific relocation specifier (if producing assembly) in this case it means emitting `sym at toc@l` which means the low 16-bits of the offset from the toc-pointer to 'sym'. Our symbol reference on the ADDItoc doesn't need any flags to modify it.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101470/new/

https://reviews.llvm.org/D101470