[PATCH] D101311: Basic block sections for functions with implicit-section-name attribute

[Snehasish Kumar via Phabricator via llvm-commits]

snehasish accepted this revision.
snehasish added a comment.
This revision is now accepted and ready to land.

lgtm



================
Comment at: llvm/lib/CodeGen/TargetLoweringObjectFileImpl.cpp:657
+    const GlobalObject *GO, SectionKind Kind, const TargetMachine &TM,
+    MCContext &Ctx, Mangler &Mang, unsigned *NextUniqueID,
+    bool Retain, bool ForceUnique) {
----------------
nit: If you use a reference here then you can remove the deref and simplify the diff.


================
Comment at: llvm/lib/CodeGen/TargetLoweringObjectFileImpl.cpp:800
+  return selectExplicitSectionGlobal(GO, Kind, TM, getContext(), getMangler(),
+                                  &NextUniqueID, Used.count(GO), false);
+}
----------------
nit: /* ForceUnique = */ false


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101311/new/

https://reviews.llvm.org/D101311