[PATCH] D101311: Basic block sections for functions with implicit-section-name attribute

[Sriraman Tallam via Phabricator via llvm-commits]

tmsriram added inline comments.


================
Comment at: llvm/lib/CodeGen/TargetLoweringObjectFileImpl.cpp:890
+        &F, Kind, TM, getContext(), getMangler(), &NextUniqueID,
+        Used.count(&F), /* ForceUnique = */true);
+  else
----------------
rahmanl wrote:
> It seems like only the last parameter is changed between this call and the one above. Maybe it is OK to change the original function's signature?
I looked at all the call sites for this function and this signature is used across MachO, COFF, etc.  Futher, all other functions that get sections use the same method. One thing I could do is to use default parameters. I am keeping it unchanged but I can modify it if you like.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101311/new/

https://reviews.llvm.org/D101311