[PATCH] D101395: [lld-macho] Implement builtin section renaming

[Greg McGary via Phabricator via llvm-commits]

gkm added a comment.

In D101395#2720897 <https://reviews.llvm.org/D101395#2720897>, @int3 wrote:

> I think we should implement features on an as-needed basis. E.g. we aren't likely to support `MH_KEXT_BUNDLE` or `MH_DYLINKER` any time in the near future, so I don't think adding code for them is worthwhile.

Done.

> Do we have use cases for `-data_const` and `-text_exec`? Also, what exactly are shared regions?



- I implemented `__DATA` -> `__DATA_CONST` renames since it's default behavior for all PIE executables, so seemed important. Regarding the command-line options, if nothing else, `-data_const` and `-no_data_const` are are useful for explicit control of the feature for the test, though without them I can also disable it for executables with `-no_pie`.

- I don't know the uses cases for -text_exec. I removed it from this diff.

- Shared regions are related to dyld shared cache, and again, I don't know that it's useful now, so I removed it from this diff.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101395/new/

https://reviews.llvm.org/D101395