[PATCH] D101395: [lld-macho] Implement builtin section renaming

[Greg McGary via Phabricator via llvm-commits]

gkm added a comment.

> Do we have use cases for `-data_const` and `-text_exec`? Also, what exactly are shared regions?



- If nothing else, `-data_const` and `-no_data_const` are useful for explicit control of the feature for the test, though without them I can also disable it for executables with `-no_pie`. I have insufficient experience with MachO code bases to know where & why the options are used in real life. The default behavior of `-data_const` for executables & dylibs puts all text into a single section and that makes implementing range-extension thunks simpler.

- For `-text_exec` ... I don't know. I can remove it. Since I really wanted the data-const stuff, and the text-exec stuff was adjacent & simple, I brought it along for the ride. I don't have a personal need for it, and we can drop it.

- Shared regions are related to dyld shared cache, whatever that is. I can remove that stuff.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101395/new/

https://reviews.llvm.org/D101395