[PATCH] D50490: Restore correct x86_64 EH encodings in kernel code model

Harald van Dijk via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 27 15:42:46 PDT 2021


hvdijk added inline comments.
Herald added a subscriber: pengfei.
Herald added a project: LLVM.


================
Comment at: llvm/trunk/lib/CodeGen/TargetLoweringObjectFileImpl.cpp:135
+        ((CM == CodeModel::Small || CM == CodeModel::Medium)
+         ? dwarf::DW_EH_PE_sdata8 : dwarf::DW_EH_PE_sdata4);
     } else {
----------------
This looks like it's the wrong way around compared to the rest. I'm also not sure why the medium code model is treated like small in the PIC case, but like large in the non-PIC case, shouldn't it be the same for both?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D50490/new/

https://reviews.llvm.org/D50490



More information about the llvm-commits mailing list