[PATCH] D101062: [AArch64][SVE] Better utilisation of immediate forms for bitwise/arith intrinsics

[Paul Walker via Phabricator via llvm-commits]

paulwalker-arm added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64SVEInstrInfo.td:342-347
+  defm SMAX_ZI   : sve_int_arith_imm1<0b00, "smax", AArch64smax_p, int_aarch64_sve_smax>;
+  defm SMIN_ZI   : sve_int_arith_imm1<0b10, "smin", AArch64smin_p, int_aarch64_sve_smin>;
+  defm UMAX_ZI   : sve_int_arith_imm1_unsigned<0b01, "umax", AArch64umax_p, int_aarch64_sve_umax>;
+  defm UMIN_ZI   : sve_int_arith_imm1_unsigned<0b11, "umin", AArch64umin_p, int_aarch64_sve_umin>;
 
+  defm MUL_ZI     : sve_int_arith_imm2<"mul", AArch64mul_p, int_aarch64_sve_mul>;
----------------
I'm surprised these changes are required.  This suggests convertMergedOpToPredOp needs updating?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101062/new/

https://reviews.llvm.org/D101062