[PATCH] D101311: Basic block sections for functions with implicit-section-name attribute

Mon Apr 26 20:53:46 PDT 2021

tmsriram marked an inline comment as done.
tmsriram added inline comments.

================
Comment at: llvm/lib/CodeGen/TargetLoweringObjectFileImpl.cpp:761-763
+  // With basic block sections, function entry must be made unique too. This
+  // works perfectly fine with section attribute or pragma section as the
+  // sections with the same name are grouped together by the assembler.
----------------
rahmanl wrote:
> Except may for chromium with its complex implementation detail here: https://chromium.googlesource.com/chromium/src/+/66.0.3359.158/base/memory/protected_memory.h
> Any thoughts on whether this would work with it (related bug: https://bugs.chromium.org/p/chromium/issues/detail?id=990942).
Section attributes work just fine with the patch. I can add another test.  This "," separated specific usage however does not seem to do anything with linux ELF.  The "," is just treated as another character. 

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101311/new/

https://reviews.llvm.org/D101311