[PATCH] D101311: Basic block sections for functions with implicit-section-name attribute
Rahman Lavaee via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Apr 26 20:06:45 PDT 2021
rahmanl added inline comments.
================
Comment at: llvm/lib/CodeGen/TargetLoweringObjectFileImpl.cpp:761-763
+ // With basic block sections, function entry must be made unique too. This
+ // works perfectly fine with section attribute or pragma section as the
+ // sections with the same name are grouped together by the assembler.
----------------
Except may for chromium with its complex implementation detail here: https://chromium.googlesource.com/chromium/src/+/66.0.3359.158/base/memory/protected_memory.h
Any thoughts on whether this would work with it (related bug: https://bugs.chromium.org/p/chromium/issues/detail?id=990942).
================
Comment at: llvm/lib/CodeGen/TargetLoweringObjectFileImpl.cpp:890
+ &F, Kind, TM, getContext(), getMangler(), &NextUniqueID,
+ Used.count(&F), /* ForceUnique = */true);
+ else
----------------
It seems like only the last parameter is changed between this call and the one above. Maybe it is OK to change the original function's signature?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D101311/new/
https://reviews.llvm.org/D101311
More information about the llvm-commits
mailing list