[PATCH] D101197: [DebugInfo][AIX] Set target debugger-tune default to dbx
Jinsong Ji via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Apr 23 14:49:43 PDT 2021
jsji added inline comments.
================
Comment at: llvm/test/DebugInfo/PowerPC/debugger-tune.ll:14-15
+
+; GDB-NOT: DW_FORM_string
+; DBX-NOT: DW_FORM_strp
+
----------------
dblaikie wrote:
> Rather than "not" maybe implicit-check-not and an active check for the positive case (otherwise if we used some futuristic alternative string encoding (like DWARFv5 strx encodings if we change to DWARFv5 by default) this test would still pass accidentally)
Good suggestion. Thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D101197/new/
https://reviews.llvm.org/D101197
More information about the llvm-commits
mailing list