[PATCH] D101197: [DebugInfo][AIX] Set target debugger-tune default to dbx

[David Blaikie via Phabricator via llvm-commits]

dblaikie added inline comments.


================
Comment at: llvm/test/DebugInfo/PowerPC/debugger-tune.ll:3
+; override defaults.
+; We use the DW_FORM_string attribute to distinguish the debuggers.
+
----------------
Maybe "We use the use of DW_FORM_string (rather than DW_FORM_strp) to distinguish debugger tuning"



================
Comment at: llvm/test/DebugInfo/PowerPC/debugger-tune.ll:14-15
+
+; GDB-NOT: DW_FORM_string
+; DBX-NOT: DW_FORM_strp
+
----------------
Rather than "not" maybe implicit-check-not and an active check for the positive case (otherwise if we used some futuristic alternative string encoding (like DWARFv5 strx encodings if we change to DWARFv5 by default) this test would still pass accidentally)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101197/new/

https://reviews.llvm.org/D101197