[PATCH] D101152: AArch64: support atomics up to 64-bits in GISel

Jessica Paquette via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 23 11:47:37 PDT 2021


paquette accepted this revision.
paquette added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/lib/Target/AArch64/GISel/AArch64InstructionSelector.cpp:2671
     uint64_t MemSizeInBytes = MemOp.getSize();
-    if (MemOp.isAtomic()) {
-      // For now we just support s8 acquire loads to be able to compile stack
----------------
Should we assert that `!MemOp.isAtomic()` or return false if `MemO.isAtomic()` in the manual selector code now?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101152/new/

https://reviews.llvm.org/D101152



More information about the llvm-commits mailing list