[PATCH] D101177: [AMDGPU] Avoid adding nullptr keys to hash table
Matt Arsenault via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Apr 23 09:36:26 PDT 2021
arsenm added inline comments.
================
Comment at: llvm/lib/Target/AMDGPU/SIInsertWaitcnts.cpp:987
+ // Conservatively add the s_waitcnt in the absence of memop data.
+ addWait(Wait, LGKM_CNT, 0);
+ } else if (SLoadAddresses.count(Ptr)) {
----------------
Doesn't this normally use a register value based dependency? Why does it need to be conservative?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D101177/new/
https://reviews.llvm.org/D101177
More information about the llvm-commits
mailing list