[PATCH] D101177: [AMDGPU] Avoid adding nullptr keys to hash table

[Piotr Sobczak via Phabricator via llvm-commits]

piotr created this revision.
Herald added subscribers: kerbowa, jfb, hiraditya, t-tye, tpr, dstuttard, yaxunl, nhaehnle, jvesely, kzhuravl, arsenm, qcolombet.
piotr requested review of this revision.
Herald added subscribers: llvm-commits, wdng.
Herald added a project: LLVM.

There is no need to keep elements with nullptr keys in
SLoadAddresses map, since they are not helpful in tracking
data dependency.

Moreover, insertions of elements with nullptr key and different
values can cause issues.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D101177

Files:
  llvm/lib/Target/AMDGPU/SIInsertWaitcnts.cpp
  llvm/test/CodeGen/AMDGPU/GlobalISel/insertelement-stack-lower.ll
  llvm/test/CodeGen/AMDGPU/gfx-callable-argument-types.ll
  llvm/test/CodeGen/AMDGPU/load-local-redundant-copies.ll
  llvm/test/CodeGen/AMDGPU/partial-sgpr-to-vgpr-spills.ll
  llvm/test/CodeGen/AMDGPU/waitcnt-vscnt.mir

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D101177.340072.patch
Type: text/x-patch
Size: 8821 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210423/dd342b23/attachment-0001.bin>