[PATCH] D101115: [AMDGPU] Move code sinking before structurizer

Piotr Sobczak via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 23 05:59:21 PDT 2021


piotr added a comment.

In D101115#2711964 <https://reviews.llvm.org/D101115#2711964>, @arsenm wrote:

> In D101115#2711462 <https://reviews.llvm.org/D101115#2711462>, @piotr wrote:
>
>> I know it is a legacy pass, but I am convinced of its usefulness in our flow - both in real-world content and lit testing (e.g., no_skip_no_successors in skip-if-dead.ll).
>
> I'm not worried about legacy, but whether it's redundant since it should have already run at this point

Some sinking is done as part of other passes, but I do not think this pass is set up to be run at any other point in our pass list.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101115/new/

https://reviews.llvm.org/D101115



More information about the llvm-commits mailing list