[PATCH] D101088: [TableGen] Correct some comments in the TableGen parser [NFC]

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 22 11:09:17 PDT 2021


dblaikie accepted this revision.
dblaikie added a comment.
This revision is now accepted and ready to land.

> I think it's okay to accept this revision myself in a day or two?

Generally this isn't an acceptable practice - the idea is that if it was worth sending for review, it should be reviewed before being submitted. (otherwise things might get a bit slippery - "I sent it for review but no one's replied, so I'm just going to commit it now")

There is sometimes narrow space for "I'm curious about feedback, but happy to commit this if no one has any" - but a change like this should be easy enough to get someone to say "I don't see anything wrong with this" when you ask.

But, yeah, something like this I think it'd be fine for you to commit without sending it for review in the first place.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101088/new/

https://reviews.llvm.org/D101088



More information about the llvm-commits mailing list