[PATCH] D101088: [TableGen] Correct some comments in the TableGen parser [NFC]
Paul C. Anagnostopoulos via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Apr 22 10:29:26 PDT 2021
Paul-C-Anagnostopoulos created this revision.
Paul-C-Anagnostopoulos added reviewers: lattner, dblaikie.
Herald added a subscriber: hiraditya.
Paul-C-Anagnostopoulos requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
This revision corrects a few comments in the TableGen parser. These are primarily comments about statement syntax.
I think it's okay to accept this revision myself in a day or two?
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D101088
Files:
llvm/lib/TableGen/TGParser.cpp
Index: llvm/lib/TableGen/TGParser.cpp
===================================================================
--- llvm/lib/TableGen/TGParser.cpp
+++ llvm/lib/TableGen/TGParser.cpp
@@ -2729,8 +2729,8 @@
/// ParseTemplateArgList - Read a template argument list, which is a non-empty
/// sequence of template-declarations in <>'s. If CurRec is non-null, these are
-/// template args for a class, which may or may not be in a multiclass. If null,
-/// these are the template args for a multiclass.
+/// template args for a class. If null, these are the template args for a
+/// multiclass.
///
/// TemplateArgList ::= '<' Declaration (',' Declaration)* '>'
///
@@ -2772,6 +2772,7 @@
/// BodyItem ::= LET ID OptionalBitList '=' Value ';'
/// BodyItem ::= Defvar
/// BodyItem ::= Assert
+///
bool TGParser::ParseBodyItem(Record *CurRec) {
if (Lex.getCode() == tgtok::Assert)
return ParseAssert(nullptr, CurRec);
@@ -3361,15 +3362,14 @@
///
/// MultiClassInst ::= MULTICLASS ID TemplateArgList?
/// ':' BaseMultiClassList '{' MultiClassObject+ '}'
+/// MultiClassObject ::= Assert
/// MultiClassObject ::= DefInst
-/// MultiClassObject ::= MultiClassInst
/// MultiClassObject ::= DefMInst
/// MultiClassObject ::= Defvar
/// MultiClassObject ::= Foreach
/// MultiClassObject ::= If
/// MultiClassObject ::= LETCommand '{' ObjectList '}'
/// MultiClassObject ::= LETCommand Object
-/// MultiClassObject ::= Assert
///
bool TGParser::ParseMultiClass() {
assert(Lex.getCode() == tgtok::MultiClass && "Unexpected token");
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D101088.339709.patch
Type: text/x-patch
Size: 1582 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210422/9545cea7/attachment.bin>
More information about the llvm-commits
mailing list