[PATCH] D100959: [AsmParser][SystemZ][z/OS] Use updated framework in AsmLexer to accept special tokens as Identifiers
Eric Astor via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Apr 22 05:57:22 PDT 2021
epastor added inline comments.
================
Comment at: llvm/include/llvm/MC/MCAsmInfo.h:207-208
+ /// a string to be lexed as an AsmToken::Identifier.
+ /// If the CommentString is also set to "#", setting this option will have
+ /// no effect, and the string will be lexed as a comment.
+ /// Defaults to false.
----------------
Is there a place where we could add a test for this behavior, if it's how we want this to behave? Is there some natural environment/configuration where we expect the CommentString to be set to "#" while AllowHashAtStartOfIdentifier is also true?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D100959/new/
https://reviews.llvm.org/D100959
More information about the llvm-commits
mailing list