[PATCH] D100959: [AsmParser][SystemZ][z/OS] Use updated framework in AsmLexer to accept special tokens as Identifiers
Anirudh Prasad via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Apr 21 10:36:44 PDT 2021
anirudhp added a comment.
In D100959#2705833 <https://reviews.llvm.org/D100959#2705833>, @myiwanch wrote:
> Just making sure I understand, this is so an identifier can start with `#` without being a comment?
No.
Currently, if the `AllowAdditionalComments` is set to true, any string starting with `#` will be lexed as a comment. This is to ensure that if it isn't lexed as a comment, we lex it as an identifier and not as an `AsmToken::Hash`. Like the comment in MCAsmInfo.h for the added attribute says:
/// If the CommentString is also set to "#", setting this option will have
/// no effect, and the string will be lexed as a comment.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D100959/new/
https://reviews.llvm.org/D100959
More information about the llvm-commits
mailing list