[PATCH] D100909: [MC] Use COMDAT for LSDA only if IR comdat type is any

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/lib/CodeGen/TargetLoweringObjectFileImpl.cpp:897
     Group = C->getName();
+    IsComdat = C->getSelectionKind() == Comdat::Any;
   }
----------------
phosek wrote:
> MaskRay wrote:
> > IsComdat -> IsComdatAny
> > 
> > 
> We use `IsComdat` elsewhere in this file so I'd prefer to keep them consistent.
But the name is now confusing. This now specifically refers to Comdat::Any. Readers could interpret IsComdat as any comdat kind.


================
Comment at: llvm/test/CodeGen/X86/elf-group-gcc_except_table.ll:1
+; Checks that the generated .gcc_except_table for function in comdat with
+; noduplicates kind is lowered to a zero-flag ELF section group.
----------------
This can be placed into gcc_except_table-multi.ll


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100909/new/

https://reviews.llvm.org/D100909