[PATCH] D100909: [MC] Use COMDAT for LSDA only if IR comdat type is any

Petr Hosek via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 20 23:54:36 PDT 2021


phosek marked an inline comment as done.
phosek added a comment.

In D100909#2703521 <https://reviews.llvm.org/D100909#2703521>, @MaskRay wrote:

> Test?

Added.



================
Comment at: llvm/lib/CodeGen/TargetLoweringObjectFileImpl.cpp:897
     Group = C->getName();
+    IsComdat = C->getSelectionKind() == Comdat::Any;
   }
----------------
MaskRay wrote:
> IsComdat -> IsComdatAny
> 
> 
We use `IsComdat` elsewhere in this file so I'd prefer to keep them consistent.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100909/new/

https://reviews.llvm.org/D100909



More information about the llvm-commits mailing list