[PATCH] D100745: [AArch64] Add AArch64TTIImpl::getMaskedMemoryOpCost function

Dave Green via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 21 05:01:40 PDT 2021


dmgreen added a comment.

Also, why is isLegalMaskedLoad returning true if there are not any legal masked loads for that type?
(Not that adding these extra costs isn't a good thing, it's good to have a better default than just 1, and a good cost is useful in many places).



================
Comment at: llvm/lib/Target/ARM/ARMTargetTransformInfo.cpp:1446
-  // generated code.
-  return cast<FixedVectorType>(Src)->getNumElements() * 8;
 }
----------------
Br and PHI are often free, but were accounted for here. I think the old code might have been fine, and more accurate for arm.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100745/new/

https://reviews.llvm.org/D100745



More information about the llvm-commits mailing list