[PATCH] D100523: [lld][MachO] Add support for LC_VERSION_MIN_* load commands

[Alexander Shaposhnikov via Phabricator via llvm-commits]

alexshap added inline comments.


================
Comment at: lld/MachO/Config.h:104
   bool demangle = false;
-  llvm::MachO::Target target;
   PlatformInfo platformInfo;
----------------
int3 wrote:
> I intentionally left this in `Config` instead of `PlatformInfo` because I didn't have to have a whole bunch of member accesses to get to something commonly used...
> 
> But maybe I should just make accessor methods so we can do things like `config->arch()` and `config->target()` instead
> 
> (I can do it after this lands)
> 
> In the future please split out these sorts of refactoring changes into a separate diff
yeah, i think having accessor methods is reasonable


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100523/new/

https://reviews.llvm.org/D100523