[PATCH] D100890: [AArch64] Remove an unnecessary parameter to AArch64CallLowering OutgoingArgHandler. NFC.

[Reid Kleckner via Phabricator via llvm-commits]

rnk added inline comments.


================
Comment at: llvm/lib/Target/AArch64/GISel/AArch64CallLowering.cpp:249
     bool Res;
-    if (Info.IsFixed && !UseVarArgsCCForFixed)
+    if (Info.IsFixed && (!UseVarArgsCCForFixed || !State.isVarArg()))
       Res = AssignFn(ValNo, ValVT, LocVT, LocInfo, Flags, State);
----------------
mstorsjo wrote:
> This makes the condition a little bit less readable again, undoing @rnk's suggestion - but using `UseVarArgsCCForFixed` here instead of `IsWin64` still is more readable though.
Honestly, I think I was being nit picky. You could calculate it locally:
  bool UseVarArgsCCForFixed = IsWin && State.isVarArg();
   if (...)

Right now the IsWin calculation is far from this use of it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100890/new/

https://reviews.llvm.org/D100890