[PATCH] D100890: [AArch64] Remove an unnecessary parameter to AArch64CallLowering OutgoingArgHandler. NFC.
Martin Storsjö via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Apr 20 14:24:30 PDT 2021
mstorsjo added inline comments.
================
Comment at: llvm/lib/Target/AArch64/GISel/AArch64CallLowering.cpp:249
bool Res;
- if (Info.IsFixed && !UseVarArgsCCForFixed)
+ if (Info.IsFixed && (!UseVarArgsCCForFixed || !State.isVarArg()))
Res = AssignFn(ValNo, ValVT, LocVT, LocInfo, Flags, State);
----------------
This makes the condition a little bit less readable again, undoing @rnk's suggestion - but using `UseVarArgsCCForFixed` here instead of `IsWin64` still is more readable though.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D100890/new/
https://reviews.llvm.org/D100890
More information about the llvm-commits
mailing list