[PATCH] D99687: [SCEV] Compute ranges for ashr/lshr recurrences

[Philip Reames via Phabricator via llvm-commits]

reames added a comment.

In D99687#2668491 <https://reviews.llvm.org/D99687#2668491>, @mkazantsev wrote:

> I couldn't find tests for the following scenarios:
>
> - Saturated ashr for positive & negative start;

test_ashr_tc_positive and test_ashr_tc_negative - not that 128 is INT_MIN for i8

> - Zero shift value (for any operation & start);

added as test_lshr_zero_shift and test_ashr_zero_shift

> - Start/end value not being power of 2 (power of 2 - 1). I am a bit worried that the boundaries of the ranges are always powers of 2, and no test shows that the rounding is correct.

Added as test_lshr_power_of_2_start, test_lshr_arbitrary_start, and test_lshr_start_power_of_2_plus_one


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99687/new/

https://reviews.llvm.org/D99687