[PATCH] D100572: [DebugInfo] Ensure DIArgList in bitcode has no null or forward metadata refs

Stephen Tozer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 20 08:26:21 PDT 2021


StephenTozer updated this revision to Diff 338878.
StephenTozer added a comment.

In the previous version of the patch, the actual `Constant` values used by the `ConstantAsMetadata` arguments to `DIArgList` were not being enumerated until the function that used them was incorporated, which resulted in incorrect bitcode output (all constant values in the bitcode are expected to appear at the module level).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100572/new/

https://reviews.llvm.org/D100572

Files:
  llvm/lib/Bitcode/Reader/MetadataLoader.cpp
  llvm/lib/Bitcode/Writer/BitcodeWriter.cpp
  llvm/lib/Bitcode/Writer/ValueEnumerator.cpp
  llvm/lib/Bitcode/Writer/ValueEnumerator.h
  llvm/test/DebugInfo/Generic/debug_value_list.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D100572.338878.patch
Type: text/x-patch
Size: 8780 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210420/c17b6c06/attachment.bin>


More information about the llvm-commits mailing list