[PATCH] D100244: [ARM] Create VMOVRRD from adjacent vector extracts

[Dave Green via Phabricator via llvm-commits]

dmgreen added inline comments.


================
Comment at: llvm/lib/Target/ARM/ARMBaseRegisterInfo.h:216
+                            const TargetRegisterClass *SrcRC,
+                            unsigned SrcSubReg) const;
 };
----------------
thakis wrote:
> This causes lots of
> 
> ```
> ../../llvm/lib/Target/ARM/ARMBaseRegisterInfo.h:213:8: warning: 'shouldRewriteCopySrc' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
>   bool shouldRewriteCopySrc(const TargetRegisterClass *DefRC,
>        ^
> ../../llvm/include/llvm/CodeGen/TargetRegisterInfo.h:579:16: note: overridden virtual function is here
>   virtual bool shouldRewriteCopySrc(const TargetRegisterClass *DefRC,
>                ^
> 1 warning generated.
> ```
> 
> The override is likely intentional and we should just add `override`?
Ah, will fix! Thanks for the report.

I'm also fixing something else to do with this patch, to do with f64 not being legal.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100244/new/

https://reviews.llvm.org/D100244