[PATCH] D100244: [ARM] Create VMOVRRD from adjacent vector extracts

[Nico Weber via Phabricator via llvm-commits]

thakis added inline comments.


================
Comment at: llvm/lib/Target/ARM/ARMBaseRegisterInfo.h:216
+                            const TargetRegisterClass *SrcRC,
+                            unsigned SrcSubReg) const;
 };
----------------
This causes lots of

```
../../llvm/lib/Target/ARM/ARMBaseRegisterInfo.h:213:8: warning: 'shouldRewriteCopySrc' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
  bool shouldRewriteCopySrc(const TargetRegisterClass *DefRC,
       ^
../../llvm/include/llvm/CodeGen/TargetRegisterInfo.h:579:16: note: overridden virtual function is here
  virtual bool shouldRewriteCopySrc(const TargetRegisterClass *DefRC,
               ^
1 warning generated.
```

The override is likely intentional and we should just add `override`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100244/new/

https://reviews.llvm.org/D100244