[PATCH] D100804: [lld-macho] Support subtractor relocations that reference sections

Jez Ng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 19 16:32:25 PDT 2021


int3 created this revision.
int3 added a reviewer: lld-macho.
Herald added a project: lld-macho.
int3 requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

The minuend (but not the subtrahend) can reference a section.

Note that we do not yet properly validate that the subtrahend isn't
referencing a section; I've filed PR50034 to track that.

I've also extended the reloc-subtractor.s test to reorder symbols, to
make sure that the addends are being associated with the minuend (and not
the subtrahend) relocation.

Fixes PR49999.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D100804

Files:
  lld/MachO/Arch/ARM64.cpp
  lld/MachO/Arch/ARM64Common.cpp
  lld/MachO/Arch/ARM64_32.cpp
  lld/MachO/Arch/X86_64.cpp
  lld/MachO/InputFiles.cpp
  lld/MachO/InputSection.cpp
  lld/test/MachO/reloc-subtractor.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D100804.338669.patch
Type: text/x-patch
Size: 9545 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210419/18b2b095/attachment.bin>


More information about the llvm-commits mailing list