[PATCH] D100755: [llvm-rc] [3/4] Run clang to preprocess input files

Adrian McCarthy via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 19 14:10:02 PDT 2021


amccarth added a comment.

I'm not quite clear on the motivation.  It's hard for me to imagine the resource compiler being useful if you cannot use the C preprocessor.  I guess for simple tests you don't need it, is that worth adding an option?

On the technical side, yeah, keeping the temp file open could be problematic.  Once you fix that, I don't see anything wrong with this patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100755/new/

https://reviews.llvm.org/D100755



More information about the llvm-commits mailing list