[PATCH] D100755: [llvm-rc] [3/4] Run clang to preprocess input files

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo added inline comments.


================
Comment at: llvm/tools/llvm-rc/llvm-rc.cpp:99
+  sys::path::append(TmpModel, "preproc.tmp%%%%%.rc");
+  Expected<sys::fs::TempFile> T = sys::fs::TempFile::create(TmpModel);
+  if (!T) {
----------------
I think I'll rewrite this to not use the `llvm::sys::TempFile` class, but instead just use `llvm::sys::createUniqueFile()` instead, as the persistent open `TempFile` seems to be causing issues when running on actual windows, see the CI failures on D100756.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100755/new/

https://reviews.llvm.org/D100755