[PATCH] D95425: Implementation of global.get/set for reftypes in LLVM IR

[Sam Clegg via Phabricator via llvm-commits]

sbc100 added inline comments.


================
Comment at: llvm/lib/Target/WebAssembly/WebAssemblyInstrMemory.td:120
+// Global GET
+def wasm_global_get_t : SDTypeProfile<1, 1, [SDTCisPtrTy<1>]>;
+def wasm_global_get : SDNode<"WebAssemblyISD::GLOBAL_GET", wasm_global_get_t,
----------------
The other names in this file seem to either use UPPER_SNAKE_CASE or CamelCase.   Any reason these new one use lower_snake_case?


================
Comment at: llvm/test/CodeGen/WebAssembly/externref-inttoptr.ll:11
+
+; CHECK-ERROR: inttoptr not supported for non-integral pointers
----------------
Missing newline at EOF here and in externref-ptrtoint.ll


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95425/new/

https://reviews.llvm.org/D95425