[PATCH] D95425: Implementation of global.get/set for reftypes in LLVM IR
    Andy Wingo via Phabricator via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Mon Apr 19 02:24:14 PDT 2021
    
    
  
wingo added inline comments.
================
Comment at: llvm/lib/Target/WebAssembly/WebAssemblyISelLowering.cpp:1334
+
+  SDVTList Tys = DAG.getVTList(VT);
+  SDValue Ops[] = {SN->getChain(), Value, Base};
----------------
Given that this node defines one value, the chain, should this be MVT::other?
Repository:
  rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95425/new/
https://reviews.llvm.org/D95425
    
    
More information about the llvm-commits
mailing list