[PATCH] D100551: [deref] No need to check nosync in addition to nofree

Sun Apr 18 21:29:38 PDT 2021

mkazantsev added a comment.

In D100551#2695408 <https://reviews.llvm.org/D100551#2695408>, @reames wrote:

> Change rejected.  the nofree function attribute does explicitly allow freeing by another thread.  See e.g. discussion here: https://reviews.llvm.org/D100141#2695360
>
> I am really curious how you stumbled into this?  There's only one currently enabled case which uses this codepath, and it has an explicit check for the GC abstract machine model which should cover your use case as I understand it?

I am planning to use this checker for loop load PRE. In case of concurrent GC, this check is too restrictive becahse nosync is never inferrable in practice.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100551/new/

https://reviews.llvm.org/D100551