[PATCH] D100551: [deref] No need to check nosync in addition to nofree

Fri Apr 16 11:26:19 PDT 2021

reames requested changes to this revision.
reames added a comment.
This revision now requires changes to proceed.

Change rejected.  the nofree function attribute does explicitly allow freeing by another thread.  See e.g. discussion here: https://reviews.llvm.org/D100141#2695360

I am really curious how you stumbled into this?  There's only one currently enabled case which uses this codepath, and it has an explicit check for the GC abstract machine model which should cover your use case as I understand it?

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100551/new/

https://reviews.llvm.org/D100551