[PATCH] D100721: [SCEVExpander] Try to create ASHR instr for expanded SCEV expr.

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Apr 18 07:09:24 PDT 2021


lebedev.ri added a comment.

Casual reminder that english isn't everyone's native language,
and tone/intent doesn't translate well.

In D100721#2697234 <https://reviews.llvm.org/D100721#2697234>, @xbolva00 wrote:

>>> If you don't mind me asking, i forgot when was the last time
>>> i have seen any (coherent?) message longer than two phrases from you;
>
>
>
> 1. Here I just agree with Florian and Nikita. Florian shared good motivation for revert (regressions and pessimized IR) and I think the revert is reasonable solution (as the problem is not so easy to solve other way), so my "+1".
>
> 2. Please avoid words like these. Really. Last warning.
>
> I would accept if you said "hey,  you wrote +1 but why do you think so? Same concerns like florian or nikita or something else?" as a productive criticism but now it looks like an aggressive tone from you.

Hm, how was that aggressive? I may be missing context here.

> - We have a freedom of speech and my comment "+1" cannot offend you.

Please do not tell other what can and what can not offend them.

> - And are you stalking me?  Do you count number of sentences in my messages on phab? Why do you judge my messages on Phab?

*You*? Nope.
All mails to -commits/-dev - yep, absolutely, simply because i read those emails.

I guess we may have different definitions for the word "judge" here,
because i'm not casting a judgment on *you*, the person,
i'm only being a bit vary of the review feedback posted.

>>> all recent comments are simply non-comments flippantly reiterating the last point made in whatever thread.
>
> Stop lying -  https://reviews.llvm.org/p/xbolva00/.

Again, i haven't actually gone and reread every comment,
i'm simply voicing my potentially-faulty observation from the reviews i have seen.

> Bluh, and are you stalking me and checking all my comments?  Do you count number of sentences in my messages on phab? Why do you even judge my messages on Phab?



> I dont think my comments are somehow bad or inappropriate, others can check it:
> https://reviews.llvm.org/p/xbolva00/

Again, i never said that. I only said that they mostly only reiterate the last point made, but not frequently make a new point.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100721/new/

https://reviews.llvm.org/D100721



More information about the llvm-commits mailing list