[PATCH] D75485: Support DW_FORM_strx* in llvm-dwp.

Igor Kudrin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 16 05:13:42 PDT 2021


ikudrin added inline comments.


================
Comment at: llvm/test/tools/llvm-dwp/X86/invalid_string_form.test:1
+RUN: not llvm-dwp %p/../Inputs/invalid_string_form.dwo -o %t 2>&1 | xargs echo
 RUN: not llvm-dwp %p/../Inputs/invalid_string_form.dwo -o %t 2>&1 | FileCheck %s
----------------
Probably, the line was added accidentally.


================
Comment at: llvm/test/tools/llvm-dwp/X86/unsupported_cu_index_version.s:6-7
 
 ## To reach the test point, no real data is needed in .debug_info.dwo,
 ## but the section should not be empty.
     .section .debug_info.dwo, "e", @progbits
----------------
The comment is outdated with the changes in `.debug_info.dwo`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75485/new/

https://reviews.llvm.org/D75485



More information about the llvm-commits mailing list