[PATCH] D75485: Support DW_FORM_strx* in llvm-dwp.

[Kim-Anh Tran via Phabricator via llvm-commits]

kimanh marked an inline comment as done.
kimanh added a comment.

Answering leftover TODOs except of the FIXME one.

This change also was rebased to origin/main, so some changes to llvm-dwp are highlighted that are not mine (lightgreen).



================
Comment at: llvm/test/tools/llvm-dwp/X86/handle_strx.test:1
+RUN: llvm-dwp %p/../Inputs/handle_strx/dw5.dwo -o %t 2>/dev/null
+RUN: llvm-dwarfdump --verbose %t 2>/dev/null | FileCheck --check-prefix=READ_STRX %s
----------------
dblaikie wrote:
> SouraVX wrote:
> > How about instead of putting raw objects files `dw5.dwo`, put it as asm file and use `llvm-mc` to generate object and `llvm-dwarfdump` and so forth.
> > 
> This was already discussed here: https://reviews.llvm.org/D75485#inline-688717
I kept tamur's test case as discussed in https://reviews.llvm.org/D75485#inline-688717 but used .s files for the new test cases. Let me know if you want me to change anything.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75485/new/

https://reviews.llvm.org/D75485