[PATCH] D100387: Simplify BitVector code
serge via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Apr 15 04:46:51 PDT 2021
serge-sans-paille added a comment.
@saugustine thanks for the revert. I'll investigate that.
@thakis I checked the instruction count and overall execution time and didn't notice much change.
@dexonsmith Yeah that was the plan: switch to SmallVector once that one, hum, validates ;-)
================
Comment at: llvm/include/llvm/ADT/BitVector.h:82
- MutableArrayRef<BitWord> Bits; // Actual bits.
- unsigned Size; // Size of bitvector in bits.
+ using Storage = std::vector<BitWord>;
+
----------------
nikic wrote:
> Any thoughts on making this `SmallVector<BitWord, 0>` instead?
You read in my mind :-) That's the next step.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D100387/new/
https://reviews.llvm.org/D100387
More information about the llvm-commits
mailing list