[PATCH] D100387: Simplify BitVector code

Duncan P. N. Exon Smith via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 14 20:12:29 PDT 2021


dexonsmith added inline comments.


================
Comment at: llvm/include/llvm/ADT/BitVector.h:82
 
-  MutableArrayRef<BitWord> Bits; // Actual bits.
-  unsigned Size;                 // Size of bitvector in bits.
+  using Storage = std::vector<BitWord>;
+
----------------
BTW, `SmallVector<BitWord, 0>` should be the same size as `MutableArrayRef` on 64-bit platforms, whereas `std::vector` is an extra word. Might be nice to avoid making `BitVector` bigger.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100387/new/

https://reviews.llvm.org/D100387



More information about the llvm-commits mailing list