[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

[Ten Tzen via Phabricator via llvm-commits]

tentzen added a comment.

  bool keepFramePointer(const MachineFunction &MF) const override;

In D80344#2673335 <https://reviews.llvm.org/D80344#2673335>, @lebedev.ri wrote:

> In D80344#2673148 <https://reviews.llvm.org/D80344#2673148>, @asmith wrote:
>
>> In D80344#2671157 <https://reviews.llvm.org/D80344#2671157>, @lebedev.ri wrote:
>>
>>> It would be good for @rjmccall / @rsmith / etc to actually finish reviewing this and accept it.
>>> I would personally want to see the next patches - what changes are needed for llvm analysis, transforms?
>>
>> All changes were provided a year ago and discussed on llvm-dev. I’m inclined to move forward unless any of the reviewers have additional comments???
>
> Could you please add relevant links to the patch description?

Hi,

In D80344#2688530 <https://reviews.llvm.org/D80344#2688530>, @lebedev.ri wrote:

> In D80344#2684450 <https://reviews.llvm.org/D80344#2684450>, @tentzen wrote:
>
>> Hi,
>
>
>
>> (Last call for review!!)
>
> Please refer to https://llvm.org/docs/CodeReview.html
>
>> Is there any more comments? This review has lasted for more than a year now. I believe I had addressed or answered all questions and concerns. Thank all reviewers' precious feedbacks.
>> For late comers, again
>> (1) Original llvm-dev [RFC] discussions can be found in these two threads below:
>> https://lists.llvm.org/pipermail/llvm-dev/2020-March/140541.html
>> https://lists.llvm.org/pipermail/llvm-dev/2020-April/141338.html
>>
>> (2) John McCall had done a thorough and insightful review. please see details above.
>
>
>
>> (3) Finally, a prototype of entire Windows SEH implementation (including both HW exception handling and local unwind) is stored in https://github.com/tentzen/llvm-project.  This prototype had been stressed by a Microsoft Windows internal SEH test suite.
>> Note this check-in is just part-1 of HW exception handling.
>
> So can you actually post the other patches as reviews?
>
>> Could please someone accept it as a record?
>> thank you!



In D80344#2688530 <https://reviews.llvm.org/D80344#2688530>, @lebedev.ri wrote:

> In D80344#2684450 <https://reviews.llvm.org/D80344#2684450>, @tentzen wrote:
>
>> Hi,
>
>
>
>> (Last call for review!!)
>
> Please refer to https://llvm.org/docs/CodeReview.html
>
>> Is there any more comments? This review has lasted for more than a year now. I believe I had addressed or answered all questions and concerns. Thank all reviewers' precious feedbacks.
>> For late comers, again
>> (1) Original llvm-dev [RFC] discussions can be found in these two threads below:
>> https://lists.llvm.org/pipermail/llvm-dev/2020-March/140541.html
>> https://lists.llvm.org/pipermail/llvm-dev/2020-April/141338.html
>>
>> (2) John McCall had done a thorough and insightful review. please see details above.
>
>
>
>> (3) Finally, a prototype of entire Windows SEH implementation (including both HW exception handling and local unwind) is stored in https://github.com/tentzen/llvm-project.  This prototype had been stressed by a Microsoft Windows internal SEH test suite.
>> Note this check-in is just part-1 of HW exception handling.
>
> So can you actually post the other patches as reviews?
>
>> Could please someone accept it as a record?
>> thank you!

Yes, I read that policy. and per policy, I waited for a week and pinged.

What other patches you were asking? LLVM HW EH Part-2 change or including Local Unwind?  
I did at first put the whole design and implementation in RFC, but I was asked to separate Local Unwind and HW exception.
So I did and submitted a patch specific for HW exception, but was asked to further divide it.
So I did, and this is part-1 for Clang.  After this patch is landed, yes I will work on next patch.

Meanwhile please refer to those RFC threads and Code/Wiki in https://github.com/tentzen/llvm-project for more details.

One step at a time, for now for this patch, is there any other feedback? thanks.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80344/new/

https://reviews.llvm.org/D80344