[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 14 04:56:37 PDT 2021


lebedev.ri added a comment.

In D80344#2684450 <https://reviews.llvm.org/D80344#2684450>, @tentzen wrote:

> Hi,



> (Last call for review!!)

Please refer to https://llvm.org/docs/CodeReview.html

> Is there any more comments? This review has lasted for more than a year now. I believe I had addressed or answered all questions and concerns. Thank all reviewers' precious feedbacks.
> For late comers, again
> (1) Original llvm-dev [RFC] discussions can be found in these two threads below:
> https://lists.llvm.org/pipermail/llvm-dev/2020-March/140541.html
> https://lists.llvm.org/pipermail/llvm-dev/2020-April/141338.html
>
> (2) John McCall had done a thorough and insightful review. please see details above.



> (3) Finally, a prototype of entire Windows SEH implementation (including both HW exception handling and local unwind) is stored in https://github.com/tentzen/llvm-project.  This prototype had been stressed by a Microsoft Windows internal SEH test suite.
> Note this check-in is just part-1 of HW exception handling.

So can you actually post the other patches as reviews?

> Could please someone accept it as a record?
> thank you!




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80344/new/

https://reviews.llvm.org/D80344



More information about the llvm-commits mailing list