[PATCH] D100489: [llvm-readobj] Fix dumping dynamic relative relocations for SHT_REL

Wed Apr 14 12:29:41 PDT 2021

arichardson planned changes to this revision.
arichardson added inline comments.

================
Comment at: llvm/test/tools/llvm-objdump/X86/elf-dynamic-relocs-rel.test:1
+## Show that llvm-objdump can dump dynamic relocations for Elf_Rel relocations
+## Previously printing the R_386_RELATIVE relocations would trigger
----------------
MaskRay wrote:
> This looks verbose.
> 
> If you just keep things as in `test/tools/llvm-readelf/ELF/reloc-types-elf-i386.test`, does it work?
> llvm-readobj generally has better support for ELF dumping and you may take inspiration from its tests.
Yes, I should have reduced this test input further, right now it's just and obj2yaml of an lld test with a few obvious lines removed. Will remove everything that's not needed for the relative relocation tomorrow.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100489/new/

https://reviews.llvm.org/D100489