[PATCH] D100489: [llvm-readobj] Fix dumping dynamic relative relocations for SHT_REL

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/test/tools/llvm-objdump/X86/elf-dynamic-relocs-rel.test:1
+## Show that llvm-objdump can dump dynamic relocations for Elf_Rel relocations
+## Previously printing the R_386_RELATIVE relocations would trigger
----------------
This looks verbose.

If you just keep things as in `test/tools/llvm-readelf/ELF/reloc-types-elf-i386.test`, does it work?
llvm-readobj generally has better support for ELF dumping and you may take inspiration from its tests.


================
Comment at: llvm/test/tools/llvm-objdump/X86/elf-dynamic-relocs-rel.test:135
+Symbols:
+  - Name:            foo
+    Section:         .text
----------------
foo is not needed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100489/new/

https://reviews.llvm.org/D100489