[PATCH] D100496: Add emitWcsLen and getInt[16|32]PtrTy helper functions

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 14 12:17:12 PDT 2021


lebedev.ri added inline comments.


================
Comment at: llvm/include/llvm/IR/IRBuilder.h:565
 
+  /// Fetch the type representing a pointer to an 16-bit integer value.
+  PointerType *getInt16PtrTy(unsigned AddrSpace = 0) {
----------------
anjankgk wrote:
> lebedev.ri wrote:
> > These two don't carry their weight.
> > In LLVM IR, pointer types are going away soon.
> Is there another substitute type for the PointerType if this is going to be removed?
I meant, the pointers will loose their pointee type.
I suggest to simply inline this into the only callee.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100496/new/

https://reviews.llvm.org/D100496



More information about the llvm-commits mailing list