[PATCH] D99254: [SVE][LoopVectorize] Fix crash in InnerLoopVectorizer::widenPHIInstruction

[Kerry McLaughlin via Phabricator via llvm-commits]

kmclaughlin accepted this revision.
kmclaughlin added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/test/Transforms/LoopVectorize/AArch64/sve-widen-phi.ll:83
+; CHECK-NEXT:    %[[VSCALE1:.*]] = call i32 @llvm.vscale.i32()
+; CHECK-NEXT:    %[[TMP1:.*]] = shl i32 %5, 2
+; CHECK-NEXT:    %[[TMP2:.*]] = sext i32 %[[TMP1]] to i64
----------------
nit: can you check for `[[VSCALE1]]` here instead of `%5`?


================
Comment at: llvm/test/Transforms/LoopVectorize/AArch64/sve-widen-phi.ll:87
+; CHECK-NEXT:    %[[LPTR2:.*]] = bitcast i32* %[[LGEP2]] to <vscale x 4 x i32>*
+; CHECK-NEXT:    %{{.*}} = load <vscale x 4 x i32>, <vscale x 4 x i32>* %[[LPTR2]], align 4
+entry:
----------------
Is it also worth adding some similar checks for `SGEP2` here?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99254/new/

https://reviews.llvm.org/D99254