[PATCH] D85288: [PowerPC] Remove implicit use register after transformToImmFormFedByLI()

ChenZheng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 13 23:44:26 PDT 2021


shchenz added a comment.

Thanks for the detailed explanation. I am thinking the `replaceInstrOperandWithImm` is functionality complete.
The issue here is checking an empty implicit operand set by `MI.implicit_operands().empty()` is not right as the `MI` is in the construction phase after calling `setDesc()`

Can we add a general function in `MachineInstr` class to check the empty implicit operand set by iterating all the operands?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85288/new/

https://reviews.llvm.org/D85288



More information about the llvm-commits mailing list