[PATCH] D99992: [mlgo] Skip AOT-compiling a model if a header/object pair is provided

Mircea Trofin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 13 09:46:57 PDT 2021


This revision was automatically updated to reflect the committed changes.
mtrofin marked an inline comment as done.
Closed by commit rGf34ef248d374: [mlgo] Skip AOT-compiling a model if a header/object pair is provided (authored by mtrofin).

Changed prior to commit:
  https://reviews.llvm.org/D99992?vs=335658&id=337191#toc

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99992/new/

https://reviews.llvm.org/D99992

Files:
  llvm/cmake/modules/TensorFlowCompile.cmake


Index: llvm/cmake/modules/TensorFlowCompile.cmake
===================================================================
--- llvm/cmake/modules/TensorFlowCompile.cmake
+++ llvm/cmake/modules/TensorFlowCompile.cmake
@@ -9,27 +9,38 @@
   endif()
 endfunction()
 
-# Run the tensorflow compiler (saved_model_cli) on the saved model in the 
+# Run the tensorflow compiler (saved_model_cli) on the saved model in the
 # ${model} directory, looking for the ${tag_set} tag set, and the SignatureDef
 # ${signature_def_key}.
-# Produce a pair of files called ${fname}.h and  ${fname}.o in the 
+# Produce a pair of files called ${fname}.h and  ${fname}.o in the
 # ${CMAKE_CURRENT_BINARY_DIR}. The generated header will define a C++ class
 # called ${cpp_class} - which may be a namespace-qualified class name.
 function(tfcompile model tag_set signature_def_key fname cpp_class)
-  tfgetmodel(${model} LLVM_ML_MODELS_ABSOLUTE)
-  message("Using model at " ${LLVM_ML_MODELS_ABSOLUTE})
   set(prefix ${CMAKE_CURRENT_BINARY_DIR}/${fname})
   set(obj_file ${prefix}.o)
   set(hdr_file ${prefix}.h)
-  add_custom_command(OUTPUT ${obj_file} ${hdr_file}
-    COMMAND "XLA_FLAGS=\"--xla_cpu_multi_thread_eigen=false\"" ${TENSORFLOW_AOT_COMPILER} aot_compile_cpu
-          --dir ${LLVM_ML_MODELS_ABSOLUTE}
-          --tag_set ${tag_set}
-          --signature_def_key ${signature_def_key}
-          --output_prefix ${prefix}
-          --cpp_class ${cpp_class}
-          --target_triple ${LLVM_HOST_TRIPLE}
-  )
+  string(TOUPPER ${fname} fname_allcaps)
+  set(override_header ${LLVM_OVERRIDE_MODEL_HEADER_${fname_allcaps}})
+  set(override_object ${LLVM_OVERRIDE_MODEL_OBJECT_${fname_allcaps}})
+  if (EXISTS "${override_header}" AND EXISTS "${override_object}")
+    configure_file(${override_header} ${hdr_file} COPYONLY)
+    configure_file(${override_object} ${obj_file} COPYONLY)
+    message("Using provided header "
+      ${hdr_file} " and object "   ${obj_file}
+      " files for model " ${model})
+  else()
+    tfgetmodel(${model} LLVM_ML_MODELS_ABSOLUTE)
+    message("Using model at " ${LLVM_ML_MODELS_ABSOLUTE})
+    add_custom_command(OUTPUT ${obj_file} ${hdr_file}
+      COMMAND "XLA_FLAGS=\"--xla_cpu_multi_thread_eigen=false\"" ${TENSORFLOW_AOT_COMPILER} aot_compile_cpu
+            --dir ${LLVM_ML_MODELS_ABSOLUTE}
+            --tag_set ${tag_set}
+            --signature_def_key ${signature_def_key}
+            --output_prefix ${prefix}
+            --cpp_class ${cpp_class}
+            --target_triple ${LLVM_HOST_TRIPLE}
+    )
+  endif()
 
   # Aggregate the objects so that results of different tfcompile calls may be
   # grouped into one target.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D99992.337191.patch
Type: text/x-patch
Size: 2666 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210413/4f960e49/attachment.bin>


More information about the llvm-commits mailing list